[SPARK-3707] [SQL] Fix bug of type coercion in DIV by chenghao-intel · Pull Request #2559 · apache/spark

chenghao-intel · 2014-09-27T14:57:26Z

Calling BinaryArithmetic.dataType will throws exception until it's resolved, but in type coercion rule Division, seems doesn't follow this.

SparkQA · 2014-09-27T15:04:24Z

QA tests have started for PR 2559 at commit 199a85d.

This patch merges cleanly.

SparkQA · 2014-09-27T17:04:25Z

Tests timed out after a configured wait of 120m.

AmplabJenkins · 2014-09-27T17:04:27Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/20917/

SparkQA · 2014-09-27T18:59:49Z

QA tests have started for PR 2559 at commit 199a85d.

This patch merges cleanly.

SparkQA · 2014-09-27T20:59:50Z

Tests timed out after a configured wait of 120m.

chenghao-intel · 2014-09-28T11:02:29Z

retest this please.

SparkQA · 2014-09-28T11:09:24Z

QA tests have started for PR 2559 at commit 199a85d.

This patch merges cleanly.

SparkQA · 2014-09-28T13:09:24Z

Tests timed out after a configured wait of 120m.

AmplabJenkins · 2014-09-28T13:09:27Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/20936/

chenghao-intel · 2014-09-30T03:28:51Z

retest this please.

SparkQA · 2014-09-30T03:34:42Z

QA tests have started for PR 2559 at commit 199a85d.

This patch merges cleanly.

SparkQA · 2014-09-30T04:24:58Z

QA tests have finished for PR 2559 at commit 199a85d.

This patch passes unit tests.
This patch merges cleanly.
This patch adds no public classes.

AmplabJenkins · 2014-09-30T04:25:01Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21018/

adrian-wang · 2014-09-30T05:25:14Z

sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisSuite.scala

Why are you changing this line? this could give more information

Thanks for noticing this, I have reverted it.

Probably we couldn't revert this, seems it leads a compiling error.

As a note it looks like importing dsl.expressions._ is the cause as it also uses ===.

SparkQA · 2014-10-01T07:14:32Z

QA tests have started for PR 2559 at commit d1c553f.

This patch merges cleanly.

SparkQA · 2014-10-01T07:19:57Z

QA tests have finished for PR 2559 at commit d1c553f.

This patch fails unit tests.
This patch merges cleanly.
This patch adds no public classes.

AmplabJenkins · 2014-10-01T07:19:59Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21096/

marmbrus · 2014-10-01T19:36:56Z

Looks like the failure is a legitimate compilation problem.

chenghao-intel · 2014-10-08T02:20:34Z

retest this please.

SparkQA · 2014-10-08T02:24:45Z

QA tests have started for PR 2559 at commit 199a85d.

This patch merges cleanly.

SparkQA · 2014-10-08T03:11:25Z

QA tests have finished for PR 2559 at commit 199a85d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

AmplabJenkins · 2014-10-08T03:11:28Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21439/Test PASSed.

chenghao-intel · 2014-10-09T00:25:38Z

@marmbrus any more comments on this?

marmbrus · 2014-10-09T01:06:52Z

Thanks, I've merged this to master.

chenghao-intel added 2 commits September 27, 2014 22:08

fix bug of type coercion in div

dc55218

Simplify the divide rule

199a85d

adrian-wang reviewed Sep 30, 2014
View reviewed changes

chenghao-intel force-pushed the type_coercion branch from d1c553f to 199a85d Compare October 8, 2014 02:19

asfgit closed this in 4ec9319 Oct 9, 2014

chenghao-intel deleted the type_coercion branch October 9, 2014 04:49

Conversation

chenghao-intel commented Sep 27, 2014

Uh oh!

SparkQA commented Sep 27, 2014

Uh oh!

SparkQA commented Sep 27, 2014

Uh oh!

AmplabJenkins commented Sep 27, 2014

Uh oh!

SparkQA commented Sep 27, 2014

Uh oh!

SparkQA commented Sep 27, 2014

Uh oh!

chenghao-intel commented Sep 28, 2014

Uh oh!

SparkQA commented Sep 28, 2014

Uh oh!

SparkQA commented Sep 28, 2014

Uh oh!

AmplabJenkins commented Sep 28, 2014

Uh oh!

chenghao-intel commented Sep 30, 2014

Uh oh!

SparkQA commented Sep 30, 2014

Uh oh!

SparkQA commented Sep 30, 2014

Uh oh!

AmplabJenkins commented Sep 30, 2014

Uh oh!

adrian-wang Sep 30, 2014

Choose a reason for hiding this comment

Uh oh!

chenghao-intel Oct 1, 2014

Choose a reason for hiding this comment

Uh oh!

chenghao-intel Oct 8, 2014

Choose a reason for hiding this comment

Uh oh!

marmbrus Oct 9, 2014

Choose a reason for hiding this comment

Uh oh!

SparkQA commented Oct 1, 2014

Uh oh!

SparkQA commented Oct 1, 2014

Uh oh!

AmplabJenkins commented Oct 1, 2014

Uh oh!

marmbrus commented Oct 1, 2014

Uh oh!

chenghao-intel commented Oct 8, 2014

Uh oh!

SparkQA commented Oct 8, 2014

Uh oh!

SparkQA commented Oct 8, 2014

Uh oh!

AmplabJenkins commented Oct 8, 2014

Uh oh!

chenghao-intel commented Oct 9, 2014

Uh oh!

marmbrus commented Oct 9, 2014

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants